feat(pam): rdp browser client#236
Merged
Merged
Conversation
Add RDCleanPath protocol support, browser RDP session handling via Gateway, and session recording capture for Windows RDP connections.
- Pass domain to connector_config_browser for AD credential injection - Preserve leftover bytes after RDCleanPath PDU parsing - Update caps.rs module doc to reflect actual codec advertisement
Stop after CredSSP on both sides and bridge MCS/capability PDUs through filter_client_mcs_connect_initial, matching the native client flow. Removes caps.rs, connector_config_browser, and the independent accept_finalize/connect_finalize calls.
Make acceptor_username an optional parameter on the existing per-platform start functions instead of having separate rdcleanpath variants. NULL/empty selects native flow, non-empty selects browser RDCleanPath flow.
run_mitm → run_mitm_native, handle_browser_session → run_mitm_rdcleanpath_inner
feat(pam): browser-based RDP support
|
💬 Discussion in Slack: #pr-review-cli-236-feat-pam-rdp-browser-client Posted by Review Police — reviews, comments, new commits, and CI failures will stream into this channel. |
|
| GitGuardian id | GitGuardian status | Secret | Commit | Filename | |
|---|---|---|---|---|---|
| 9387833 | Triggered | Generic Password | c111230 | packages/pam/handlers/rdp/native/src/rdcleanpath.rs | View secret |
| 9387833 | Triggered | Generic Password | 1ccc772 | packages/pam/handlers/rdp/native/src/rdcleanpath.rs | View secret |
🛠 Guidelines to remediate hardcoded secrets
- Understand the implications of revoking this secret by investigating where it is used in your code.
- Replace and store your secrets safely. Learn here the best practices.
- Revoke and rotate these secrets.
- If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.
To avoid such incidents in the future consider
- following these best practices for managing and storing secrets including API keys and other credentials
- install secret detection on pre-commit to catch secret before it leaves your machine and ease remediation.
🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.
sheensantoscapadngan
previously approved these changes
May 18, 2026
sheensantoscapadngan
approved these changes
May 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description 📣
Type ✨
Tests 🛠️
# Here's some code block to paste some code snippets